Support for Hardhat Network #1043

iamdefinitelyahuman · 2021-04-06T22:53:46Z

What I did

Add preliminary support for Hardhat Network as a testing environment.

To test this, you must currently install the hardhat@dtt package. The required features for this integration will not merge to the main hardhat repo until after the Berlin fork, in the mean time this PR should also be considered a WIP.

To test, create a Brownie project and then install hardhat inside it:

brownie init
npm install --save-dev hardhat@dtt
touch hardhat.config.js

You can now use hardhat as a dev environment with --network hardhat or hardhat fork mode using --network hardhat-fork.

How I did it

Most of the groundwork for this was laid in previous PRs (#997, #998). The integration is made possible via a new backend module and a hardhat-specific middleware.

How to verify it

Try it! And please report any issues you encounter.

TODO

Before this merges, the test suite should be modified to target both hardhat and ganache. We also need to start use this in our daily lives and smoke out any weird edge cases or other oddities.

Closes #1024
Closes #1025
Closes #1026
Closes #1027

BlinkyStitt · 2021-04-07T00:12:47Z

Looks great! I think this covers everything I ran into.

banteg

[hardhat] Incorrect transaction gas limit #1024 Fixed --network hardhat-fork doesn't work yet, all transactions fail with ValueError: Transaction gas limit is 12475600 and exceeds block gas limit of 9500000. Fixed by overriding the limit when creating a hardhat config.
[hardhat] unlocked account is missing #1025 Tested, impersonation works well.
[hardhat] network config adds incompatible flags #1026 Tested, one caveat. Spawning hardhat fails because it seems to go into an interactive prompt suggesting creating a project. Brownie should create hardhat.config.js prior to spawning hardhat. Fixed in suggestion.
[hardhat] brownie reverts context manager does not catch reverts #1027 Fixed brownie.reverts doesn't work properly, getting ValueError: Transaction reverted without a reason instead. Fixed from Brownie side. The issue also mentions a fix via hardhat config.

brownie/network/middlewares/hardhat.py

brownie/network/rpc/hardhat.py

banteg

Fixed all mentioned issues in suggestions. Looks good after that.

brownie/network/rpc/hardhat.py

banteg · 2021-04-07T04:00:02Z

There are still problems, cont'd in #1044

iamdefinitelyahuman · 2021-04-07T12:22:38Z

Need to expose https://hardhat.org/guides/mainnet-forking.html#pinning-a-block and think about some sensible defaults for it

iamdefinitelyahuman · 2021-04-07T12:23:04Z

Also lots of potentially interesting stuff here: https://hardhat.org/hardhat-network/#mining-modes

banteg · 2021-04-07T12:30:26Z

Seems like one quality of life improvement would be an ability to inject Hardhat config via RPC.

banteg · 2021-04-07T15:23:18Z

Pls cherry pick this too a06a35f

PatrickAlphaC · 2021-04-07T17:55:24Z

This is beautiful.

Just ran a few tests.... they are so FAST!

I did have to add the network though: brownie networks add development hardhat cmd='npx hardhat node' host=http://127.0.0.1 port=8545

Might be good to have that in the docs too.

iamdefinitelyahuman · 2021-04-08T23:18:15Z

Some weird inconsistencies between ganache and hardhat with how time is handled.

Implementing #709 alongside this could help

banteg · 2021-04-19T19:30:48Z

hardhat@dtt.1 additionally prefixes error messages with "Error: ", not sure if the change is intended.

A fix could look like this, but ideally we need to use error codes to not depend on parsing error messages.

message = result["error"]["message"].replace('Error: ', '')  # fix for hardhat@dtt.1

PatrickAlphaC · 2021-05-19T18:18:04Z

Bump, what does this need to move forward?

iamdefinitelyahuman · 2021-05-19T18:39:08Z

was waiting for hardhat official release - we got that a few days ago, now i guess the blocker is probably me? really just needs another round of testing and rechecking that everything works as expected, updates to docs... i'm on vacation at the moment tho so moving slowly.

PatrickAlphaC · 2021-05-26T15:35:43Z

Have an awesome vacation! Let me know how I can help here. Going to update most of the packages I worked on with hardhat support.

pandadefi · 2021-08-02T08:53:45Z

How can I help?

iamdefinitelyahuman · 2021-08-07T14:17:29Z

This is mostly working. The test suite fails from 3 broad issues:

Hardhat returns 21,001 instead of 21,000 when estimating gas on a plain tx, so a bunch of places in brownie's test suite break due to an assumption of 21,000.
Hardhat sets a default of 10,000 ether per account, which breaks assumptions around 100 ether per account (ganache's default).
The lack of a global hardhat install breaks any tests that involve sub-processes launching in different folders, Mostly this affects the tests of the pytest plugin.

I think this is far enough along to launch it as a sort-of beta integration. As we use it in prod we'll find issues and shortcomings and I'm sure in a month or 2 it will look better than it does today. But for now.. lfgggggg

iamdefinitelyahuman · 2021-08-07T14:18:08Z

Docs updates will come in another PR, I need to do some updates around the EIP1559 functionality as well prior to pushing out a 1.16.0 release.

sambacha · 2021-08-08T01:04:39Z

@iamdefinitelyahuman: 3. The lack of a global hardhat install breaks any tests that involve sub-processes launching in different folders, Mostly this affects the tests of the pytest plugin.

by global hardhat install, do you mean hh? see: https://www.npmjs.com/package/hardhat-shorthand

banteg reviewed Apr 7, 2021

View reviewed changes

brownie/network/middlewares/hardhat.py Outdated Show resolved Hide resolved

brownie/network/rpc/hardhat.py Show resolved Hide resolved

brownie/network/rpc/hardhat.py Show resolved Hide resolved

banteg previously approved these changes Apr 7, 2021

View reviewed changes

brownie/network/rpc/hardhat.py Show resolved Hide resolved

iamdefinitelyahuman dismissed banteg’s stale review via 58414e9 April 7, 2021 10:22

iamdefinitelyahuman mentioned this pull request Apr 7, 2021

Hardhat compatibility fixes #1044

Closed

iamdefinitelyahuman force-pushed the feat-hardhat branch from 0903fba to 89e366c Compare April 7, 2021 16:16

banteg mentioned this pull request Apr 19, 2021

test: hardhat compatibility yearn/yearn-vaults#268

Merged

iamdefinitelyahuman mentioned this pull request Jul 4, 2021

Add support for console.log #480

Open

iamdefinitelyahuman force-pushed the feat-hardhat branch 3 times, most recently from af6ecaa to 9709ecd Compare August 7, 2021 00:12

iamdefinitelyahuman mentioned this pull request Aug 7, 2021

Split CI into multiple workflows #1185

Merged

iamdefinitelyahuman added 6 commits August 7, 2021 13:46

feat: hardhat rpc backend

d9785a7

feat: hardhat middleware

70b8357

fix: do not expect pc in error string

01e506f

feat: add hardhat and hardhat-fork networks

18a3d84

fix: update failing test

0786c0c

fix: handle non-VM exceptions

0170831

banteg and others added 11 commits August 7, 2021 13:46

fix: cast rpc sleep response to int

2003bea

feat: capture hardhat reverts

6f82d26

fix: handle non-default network use with xdist

9d06356

fix: ignore chain id

2c3ade1

fix: set block gas limit upon connection

40449e5

feat: default hardhat config

236df29

fix: adjust time offset after transactions

546916f

fix: formatting for eth_call

f9c296c

fix: autogenerate correct config file

eb08ff3

fix: update hardhat middleware

190a216

fix: check for config file in parent folders

6eb8b40

iamdefinitelyahuman force-pushed the feat-hardhat branch from 9709ecd to 6eb8b40 Compare August 7, 2021 14:12

banteg approved these changes Aug 7, 2021

View reviewed changes

iamdefinitelyahuman merged commit c723b88 into master Aug 7, 2021

iamdefinitelyahuman deleted the feat-hardhat branch August 7, 2021 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Hardhat Network #1043

Support for Hardhat Network #1043

iamdefinitelyahuman commented Apr 6, 2021 •

edited

Loading

BlinkyStitt commented Apr 7, 2021

banteg left a comment •

edited

Loading

banteg left a comment •

edited

Loading

banteg commented Apr 7, 2021

iamdefinitelyahuman commented Apr 7, 2021

iamdefinitelyahuman commented Apr 7, 2021

banteg commented Apr 7, 2021

banteg commented Apr 7, 2021

PatrickAlphaC commented Apr 7, 2021 •

edited

Loading

iamdefinitelyahuman commented Apr 8, 2021

banteg commented Apr 19, 2021

PatrickAlphaC commented May 19, 2021

iamdefinitelyahuman commented May 19, 2021

PatrickAlphaC commented May 26, 2021 •

edited

Loading

pandadefi commented Aug 2, 2021

iamdefinitelyahuman commented Aug 7, 2021

iamdefinitelyahuman commented Aug 7, 2021

sambacha commented Aug 8, 2021

Support for Hardhat Network #1043

Support for Hardhat Network #1043

Conversation

iamdefinitelyahuman commented Apr 6, 2021 • edited Loading

What I did

How I did it

How to verify it

TODO

BlinkyStitt commented Apr 7, 2021

banteg left a comment • edited Loading

Choose a reason for hiding this comment

banteg left a comment • edited Loading

Choose a reason for hiding this comment

banteg commented Apr 7, 2021

iamdefinitelyahuman commented Apr 7, 2021

iamdefinitelyahuman commented Apr 7, 2021

banteg commented Apr 7, 2021

banteg commented Apr 7, 2021

PatrickAlphaC commented Apr 7, 2021 • edited Loading

iamdefinitelyahuman commented Apr 8, 2021

banteg commented Apr 19, 2021

PatrickAlphaC commented May 19, 2021

iamdefinitelyahuman commented May 19, 2021

PatrickAlphaC commented May 26, 2021 • edited Loading

pandadefi commented Aug 2, 2021

iamdefinitelyahuman commented Aug 7, 2021

iamdefinitelyahuman commented Aug 7, 2021

sambacha commented Aug 8, 2021

iamdefinitelyahuman commented Apr 6, 2021 •

edited

Loading

banteg left a comment •

edited

Loading

banteg left a comment •

edited

Loading

PatrickAlphaC commented Apr 7, 2021 •

edited

Loading

PatrickAlphaC commented May 26, 2021 •

edited

Loading